DEP PHP Support in CMS5 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sabina-talipova
force-pushed
the
pulls/5/upgarde-cms5
branch
2 times, most recently
from
1eeeb2b to
4068c8d
Compare
This was referenced Dec 22, 2022
emteknetnz
previously requested changes
Jan 10, 2023
sabina-talipova
force-pushed
the
pulls/5/upgarde-cms5
branch
from
4068c8d to
840aac4
Compare
maxime-rainville
requested changes
Jan 16, 2023
sabina-talipova
force-pushed
the
pulls/5/upgarde-cms5
branch
from
840aac4 to
99b454b
Compare
| @@ -34,6 +34,10 @@ class SecurityAdminExtension extends Extension | |||
| 'reset', | |||
| ]; | |||
|
|
|||
| private static $url_handlers = [ | |||
There was a problem hiding this comment.
We change the SecurityAdmin to be a plain ModelAdmin. A side affect of that seems to be that we can create REST endpoints directly on this controller anymore.
MFA has a "reset" endpoint on Security used to trigger a force reset of a Member MFA settings.
I change that endpoint to be users/reset/$ID instead of reset/$ID.
…turned type for Email::send()
| } catch (Exception $e) { | ||
| $this->logger->info('WARNING: Account Reset Email failed to send: ' . $e->getMessage()); | ||
| return false; | ||
| } | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
Email::send() now return void. We'll consider the Email sending a success if no exceptions are thrown.
maxime-rainville
approved these changes
Jan 17, 2023
emteknetnz
approved these changes
Jan 17, 2023
|
Note - I found an issue with this post merge where registered methods aren't showing in SecurityAdmin - we'll deal with this post-beta - #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue